[PM-15190] hide empty ciphers from autofill #12491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
evan-livefront
changed the title
jprusik
reviewed
Dec 20, 2024
Comment on lines
+561
to
+581
| switch (cipher.type) { | ||
| case CipherType.Card: | ||
| if (areKeyValuesNull(cipher.card)) { | ||
| continue; | ||
| } | ||
| break; | ||
|
|
||
| case CipherType.Identity: | ||
| if (areKeyValuesNull(cipher.identity)) { | ||
| continue; | ||
| } | ||
| break; | ||
|
|
||
| case CipherType.Login: | ||
| if ( | ||
| areKeyValuesNull(cipher.login, ["username", "password", "totp", "fido2Credentials"]) | ||
| ) { | ||
| continue; | ||
| } | ||
| break; | ||
| } |
jprusik
previously approved these changes
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12491 +/- ##
=======================================
Coverage 33.73% 33.73%
=======================================
Files 2918 2918
Lines 90994 91007 +13
Branches 17200 17205 +5
=======================================
+ Hits 30693 30701 +8
- Misses 57901 57905 +4
- Partials 2400 2401 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15190
📔 Objective
Cards, Logins, and Identities with fields filled out no longer appear in autofill dropdown
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes